-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build casacore 3.5.0 on macOS #9
Conversation
Use latest stable version from GitHub. The new Dysco storage manager needs GSL, and Python 2 support is now disabled by default.
We need a new stable version every two months...
Since we don't install the Python 2 bindings (called "python") anymore, it is safe to remove patches to that part of the code. Replace the old patch with a fix to the Dysco tests which was recently added to the development version in casacore/casacore#1350. This should be removed when we move to the next casacore release.
We almost always want Python bindings. Rather disable Python explicitly with `--without-python` in case you don't.
This is mostly to advertise the git replace mechanism used to link the older (ska-sa) commits before 2021 to the latest casacore project ones. This step (done per cloned local repository) allows `git log`, `git blame` and other commands to treat the two disparate histories as one. For the record, I followed these instructions: https://steemit.com/git/@sushrest/merging-2-repositories-to-preserve-history-using-grafting
I ran `brew tap-new --no-git test/tap` to get the latest GitHub workflows and copied the template over the existing ones. I might as well mention brew bundles in the README as well.
The tests pass again and we have bottles :-) |
I have tested this together with https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I have not tested the bottles on my machine.
Ideally I would have liked to rename master branch to main instead, but this is in the midst of a PR with an open branch and it would therefore have been messy.
I tried the I don't want to remove the release either, as it has a tag and all, so for now I'm just merging the PR like in the past. |
Build casacore 3.5.0 on macOS
casacore-data
measures, for what it's worth.