Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build casacore 3.5.0 on macOS #9

Merged
merged 9 commits into from
Jun 20, 2024
Merged

Build casacore 3.5.0 on macOS #9

merged 9 commits into from
Jun 20, 2024

Conversation

ludwigschwardt
Copy link
Collaborator

@ludwigschwardt ludwigschwardt commented Jun 12, 2024

  • Build the released casacore 3.5.0.
  • I had to include the Add missing include in test casacore#1350 fix as a temporary patch. I also removed an old Python 2 patch. We should be patch-free after the next release 🙂
  • Build Python bindings by default now, as I keep on forgetting to specify it. Who doesn't need it anyway? The upside is that we can now have Python-enabled bottles for the first time 🎉
  • Upgraded the Homebrew actions so that tests pass and we have bottles (ventura-intel and sonoma-arm).
  • Updated casacore-data measures, for what it's worth.
  • Advertise my nifty historical graft to make older commits visible during logs and blames.

Use latest stable version from GitHub.

The new Dysco storage manager needs GSL, and Python 2 support is now
disabled by default.
We need a new stable version every two months...
Since we don't install the Python 2 bindings (called "python") anymore,
it is safe to remove patches to that part of the code.

Replace the old patch with a fix to the Dysco tests which was recently
added to the development version in casacore/casacore#1350. This should
be removed when we move to the next casacore release.
We almost always want Python bindings. Rather disable Python explicitly
with `--without-python` in case you don't.
This is mostly to advertise the git replace mechanism used to link
the older (ska-sa) commits before 2021 to the latest casacore project
ones. This step (done per cloned local repository) allows `git log`,
`git blame` and other commands to treat the two disparate histories
as one.

For the record, I followed these instructions:

https://steemit.com/git/@sushrest/merging-2-repositories-to-preserve-history-using-grafting
@ludwigschwardt ludwigschwardt requested a review from tammojan June 12, 2024 13:37
I ran `brew tap-new --no-git test/tap` to get the latest GitHub
workflows and copied the template over the existing ones. I might as
well mention brew bundles in the README as well.
@ludwigschwardt
Copy link
Collaborator Author

The tests pass again and we have bottles :-)

@ludwigschwardt
Copy link
Collaborator Author

I have tested this together with python-casacore on a real MS, so it works at some level... Please note that the "brew bot" suggests labelling this as pr-pull to complete the bottling process. More here:

https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/

Copy link
Contributor

@tammojan tammojan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I have not tested the bottles on my machine.

@ludwigschwardt ludwigschwardt added pr-pull Trigger brewbot's bottle export, close PR don't merge and removed don't merge pr-pull Trigger brewbot's bottle export, close PR labels Jun 20, 2024
Ideally I would have liked to rename master branch to main instead, but
this is in the midst of a PR with an open branch and it would therefore
have been messy.
@ludwigschwardt ludwigschwardt added pr-pull Trigger brewbot's bottle export, close PR don't merge and removed don't merge pr-pull Trigger brewbot's bottle export, close PR labels Jun 20, 2024
@ludwigschwardt
Copy link
Collaborator Author

ludwigschwardt commented Jun 20, 2024

I tried the pr-pull approach but it is now a bit borked... The first time it succeeded to upload macOS bottles as release assets but then crashed because main branch was missing. The second time it did not like that the assets are already there.

I don't want to remove the release either, as it has a tag and all, so for now I'm just merging the PR like in the past.

@ludwigschwardt ludwigschwardt changed the title Build casacore 3.5.0 Build casacore 3.5.0 on macOS Jun 20, 2024
@ludwigschwardt ludwigschwardt merged commit 8906caa into master Jun 20, 2024
4 of 5 checks passed
ludwigschwardt added a commit that referenced this pull request Jun 20, 2024
Build casacore 3.5.0 on macOS
@ludwigschwardt ludwigschwardt deleted the casacore-3.5.0 branch June 20, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants